RFR: 8336316: JFR: Use SettingControl::getValue() instead of setValue() for ActiveSetting event

Markus Grönlund mgronlun at openjdk.org
Wed Jul 24 15:07:33 UTC 2024


On Sat, 13 Jul 2024 16:43:40 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that makes the ActiveSetting event act differently when an invalid value is specified.
> 
> Previously the last set value was used, but now the result of getValue() is returned. In case Control::getLastValue() returns null, the default value  is used.  Benefit of this change is to make it easier to diagnose setting related issues. The event will reports the actual state of the event setting, not what happens to have been specified.
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/20172#pullrequestreview-2197017664


More information about the hotspot-jfr-dev mailing list