Integrated: 8336316: JFR: Use SettingControl::getValue() instead of setValue() for ActiveSetting event

[Erik Gahlin]

On Sat, 13 Jul 2024 16:43:40 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that makes the ActiveSetting event act differently when an invalid value is specified.
> 
> Previously the last set value was used, but now the result of getValue() is returned. In case Control::getLastValue() returns null, the default value  is used.  Benefit of this change is to make it easier to diagnose setting related issues. The event will report the actual state of the event setting, not what happens to have been specified.
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

This pull request has now been integrated.

Changeset: b2599f8b
Author:    Erik Gahlin <egahlin at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/b2599f8b0ed227f7b67fbbb77b4a5af1f12730e2
Stats:     7 lines in 1 file changed: 3 ins; 1 del; 3 mod

8336316: JFR: Use SettingControl::getValue() instead of setValue() for ActiveSetting event

Reviewed-by: mgronlun

-------------

PR: https://git.openjdk.org/jdk/pull/20172