RFR: 8327884: JFR view: Improve time display accuracy to milliseconds
Erik Gahlin
egahlin at openjdk.org
Tue Mar 12 09:23:15 UTC 2024
On Tue, 12 Mar 2024 07:45:37 GMT, Long Yang <lyang at openjdk.org> wrote:
> Could I have a review of this patch for [8327884](https://bugs.openjdk.org/browse/JDK-8327884) ?
>
> Now the time display accuracy is seconds. It's better if we can display milliseconds, especially when printing original events.
> This is a break change, consider this is a command line utility, it's acceptable.
>
> Testing:
> test/jdk/jdk/jfr/tool/TestView.java
> test/jdk/jdk/jfr/jcmd/TestJcmdView.java
>
> All passed.
>
> Thanks
Why is milliseconds precision needed for timestamps? It was tried when the jfr tool was developed, but it was too noisy and with little benefit. Timespans on the other hand, for example, GC pauses, have higher precision and all durations shorter than 1 s is in milliseconds so it easy to compare values.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18219#issuecomment-1991134127
More information about the hotspot-jfr-dev
mailing list