RFR: 8327884: JFR view: Improve time display accuracy to milliseconds
Long Yang
lyang at openjdk.org
Tue Mar 12 13:15:12 UTC 2024
On Tue, 12 Mar 2024 07:45:37 GMT, Long Yang <lyang at openjdk.org> wrote:
> Could I have a review of this patch for [8327884](https://bugs.openjdk.org/browse/JDK-8327884) ?
>
> Now the time display accuracy is seconds. It's better if we can display milliseconds, especially when printing original events.
> This is a break change, consider this is a command line utility, it's acceptable.
>
> Testing:
> test/jdk/jdk/jfr/tool/TestView.java
> test/jdk/jdk/jfr/jcmd/TestJcmdView.java
>
> All passed.
>
> Thanks
In most cases, accuracy to seconds is sufficient.
If it is a custom event, and the event start time accurate to milliseconds is of special significance to the developer, for this scenario, display to milliseconds is what developers expected.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18219#issuecomment-1991623151
More information about the hotspot-jfr-dev
mailing list