RFR: 8327884: JFR view: Improve time display accuracy to milliseconds
Long Yang
lyang at openjdk.org
Thu Mar 14 13:31:38 UTC 2024
On Tue, 12 Mar 2024 07:45:37 GMT, Long Yang <lyang at openjdk.org> wrote:
> Could I have a review of this patch for [8327884](https://bugs.openjdk.org/browse/JDK-8327884) ?
>
> Now the time display accuracy is seconds. It's better if we can display milliseconds, especially when printing original events.
> This is a break change, consider this is a command line utility, it's acceptable.
>
> Testing:
> test/jdk/jdk/jfr/tool/TestView.java
> test/jdk/jdk/jfr/jcmd/TestJcmdView.java
>
> All passed.
>
> Thanks
In addition to the custom events mentioned above, currently existing tools display to millisecond precision (such as JMC, jfr print), so another reason is due to usage habits. I was thinking about it for a while yesterday, but I didn’t think of a particularly good example like the XYZ you mentioned. At present, it seems that accuracy to the second should be enough. If you have no objection, I can close this PR.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18219#issuecomment-1997464091
More information about the hotspot-jfr-dev
mailing list