RFR: 8327884: JFR view: Improve time display accuracy to milliseconds

Long Yang lyang at openjdk.org
Thu Mar 14 13:39:39 UTC 2024


On Tue, 12 Mar 2024 07:45:37 GMT, Long Yang <lyang at openjdk.org> wrote:

> Could I have a review of this patch for [8327884](https://bugs.openjdk.org/browse/JDK-8327884) ?
> 
> Now the time display accuracy is seconds. It's better if we can display milliseconds, especially when printing original events.
> This is a break change, consider this is a command line utility, it's acceptable.
> 
> Testing:
> test/jdk/jdk/jfr/tool/TestView.java
> test/jdk/jdk/jfr/jcmd/TestJcmdView.java
> 
> All passed.
> 
> Thanks

If you don't mind, I'd like to ask another question. Now the default is to print out all events, and sorting by specified fields is not supported. I wonder if we can add options to limit the number of events, such as displaying the first 10 events (`--limit 10`), or displaying the 101st to 110th events (`--limit 101,10`). I feel that the built-in query statements of `jfr view` are more flexible. If the statement capabilities can be released earlier, the sorting and quantity limit capabilities can also be achieved.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18219#issuecomment-1997481030


More information about the hotspot-jfr-dev mailing list