RFR: 8343946: JFR: Wildcard should only work with COUNT for 'jfr view'

Erik Gahlin egahlin at openjdk.org
Mon Nov 11 18:46:32 UTC 2024


Could I have a review of a PR that fixes a query validation bug for 'jfr view'?

When '*' is used as a field name with an aggregator function, the implementation defaults to using the 'startTime' field, resulting in the field expression COUNT(startTime). Unfortunately, this behavior allows the aggregate function to bypass validation. This issue can be fixed by checking against the actual text rather than the field name.

The lack of validation led to incorrect numbers being used for the 'Threads' column in the contention-by-address view.

Testing: jdk/jdk/jfr and manual inspection.

Thanks,
Erik

-------------

Commit messages:
 - Initial

Changes: https://git.openjdk.org/jdk/pull/22018/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22018&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8343946
  Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/22018.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22018/head:pull/22018

PR: https://git.openjdk.org/jdk/pull/22018


More information about the hotspot-jfr-dev mailing list