RFR: 8343946: JFR: Wildcard should only work with COUNT for 'jfr view'

[Markus Grönlund]

On Mon, 11 Nov 2024 17:22:58 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a PR that fixes a query validation bug for 'jfr view'?
> 
> When '*' is used as a field name with an aggregator function, the implementation defaults to using the 'startTime' field, resulting in the field expression COUNT(startTime). Unfortunately, this behavior allows the aggregate function to bypass validation. This issue can be fixed by checking against the actual text rather than the field name.
> 
> The lack of validation led to incorrect numbers being used for the 'Threads' column in the contention-by-address view.
> 
> Testing: jdk/jdk/jfr and manual inspection.
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22018#pullrequestreview-2427972982