RFR: 8343057: JFR: Sorting in 'jfr view' can violate contract [v2]

[Markus Grönlund]

On Tue, 29 Oct 2024 22:54:24 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of a change that improves the comparator used with 'jfr view'?
>> 
>> Testing: jdk/jdk/jfr + comparison of output from 'jfr view all-views' before and after the change
>> 
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update

src/jdk.jfr/share/classes/jdk/jfr/internal/query/TableSorter.java line 74:

> 72: 
> 73:         private static int compareObjects(Object a, Object b) {
> 74:             if (a == b) {

What case is most likely? Is null == null a valid comparison?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21713#discussion_r1818075461