RFR: 8343057: JFR: Sorting in 'jfr view' can violate contract [v2]

[Erik Gahlin]

On Sun, 27 Oct 2024 12:12:02 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/query/TableSorter.java line 74:
> 
>> 72: 
>> 73:         private static int compareObjects(Object a, Object b) {
>> 74:             if (a == b) {
> 
> What case is most likely? Is null == null a valid comparison?

It's valid, I like to remove the case a == b first to simplify logic if only one value is null.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21713#discussion_r1824795871