RFR: 8354310: JFR: Inconsistent metadata in ZPageAllocation
Stefan Karlsson
stefank at openjdk.org
Thu Apr 10 16:23:27 UTC 2025
On Thu, 10 Apr 2025 15:43:15 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:
> Hello,
>
> This PR fixes JFR metadata for ZPageAllocation after [JDK-8350441](https://bugs.openjdk.org/browse/JDK-8350441).
src/hotspot/share/jfr/metadata/metadata.xml line 1162:
> 1160: <Field type="ulong" contentType="bytes" name="harvested" label="Harvested" />
> 1161: <Field type="ulong" contentType="bytes" name="committed" label="Committed" />
> 1162: <Field type="uint" name="harvestedRanges" label="Harvested Ranges" description="Number of ranges memory is harvested from" />
Maybe "Number of harvested memory ranges"?
src/hotspot/share/jfr/metadata/metadata.xml line 1165:
> 1163: <Field type="boolean" name="multiPartition" label="Multi-Partition Allocation" />
> 1164: <Field type="boolean" name="successful" label="Successful Allocation" />
> 1165: <Field type="boolean" name="nonBlocking" label="Non-Blocking" />
I wonder if "Allocation" is redundant here. If not then maybe it should also say Non-Blocking Allocation.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24578#discussion_r2037796280
PR Review Comment: https://git.openjdk.org/jdk/pull/24578#discussion_r2037797534
More information about the hotspot-jfr-dev
mailing list