RFR: 8354310: JFR: Inconsistent metadata in ZPageAllocation [v2]
Joel Sikström
jsikstro at openjdk.org
Thu Apr 10 19:04:45 UTC 2025
On Thu, 10 Apr 2025 16:20:28 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
>>
>> stefank feedback
>
> src/hotspot/share/jfr/metadata/metadata.xml line 1165:
>
>> 1163: <Field type="boolean" name="multiPartition" label="Multi-Partition Allocation" />
>> 1164: <Field type="boolean" name="successful" label="Successful Allocation" />
>> 1165: <Field type="boolean" name="nonBlocking" label="Non-Blocking" />
>
> I wonder if "Allocation" is redundant here. If not then maybe it should also say Non-Blocking Allocation.
I agree and feel like it's redundant. I'll remove "Allocation" from the labels of multiPartition and successful.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24578#discussion_r2038100347
More information about the hotspot-jfr-dev
mailing list