RFR: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
KIRIYAMA Takuya
duke at openjdk.org
Tue Apr 15 05:23:15 UTC 2025
Hi All,
I would like to add this bug fix for the bug in jdk/jfr/startupargs/TestMemoryOptions.java.
I was unable to reproduce the reported problem in java versions 11 and later. Therefore, I made a pull request for 8u before.
https://github.com/openjdk/jdk8u-dev/pull/641
However, the latest java should be fixed, as the bugs described below will potentially remain in the test.
This test contains 24 test cases and fails the "ThreadBufferSizeExceedMemorySize" case.
The cause of this bug is the memory allocation issue, which occurs only on 32-bit Server VM, not on Client VM or 64-bit JDK. The failure happens because Server VM's default heap size reduces available memory space, causing JFR to fail memory allocation.
To resolve this issue, -Xmx256M is explicitly set, matching the Client VM default heap size, ensuring sufficient memory space remains available for JFR.
I believe that this test verifies that the combination of memory options for JFR is valid or invalid and that the MaxHeapSize setting does not affect the verification.
Change has been verified locally, test-fix only, no risk.
Would someone please review this fix?
-------------
Commit messages:
- 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build
Changes: https://git.openjdk.org/jdk/pull/24646/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24646&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8352942
Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/24646.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24646/head:pull/24646
PR: https://git.openjdk.org/jdk/pull/24646
More information about the hotspot-jfr-dev
mailing list