RFR: 8352942: jdk/jfr/startupargs/TestMemoryOptions.java fails with 32-bit build

[Paul Hohensee]

On Tue, 15 Apr 2025 05:18:34 GMT, KIRIYAMA Takuya <duke at openjdk.org> wrote:

> Hi All,
> I would like to add this bug fix for the bug in jdk/jfr/startupargs/TestMemoryOptions.java. 
> I was unable to reproduce the reported problem in java versions 11 and later. Therefore, I made a pull request for 8u before.
> https://github.com/openjdk/jdk8u-dev/pull/641
> However, the latest java should be fixed, as the bugs described below will potentially remain in the test.
> 
> This test contains 24 test cases and fails the "ThreadBufferSizeExceedMemorySize" case.
> The cause of this bug is the memory allocation issue, which occurs only on 32-bit Server VM, not on Client VM or 64-bit JDK. The failure happens because Server VM's default heap size reduces available memory space, causing JFR to fail memory allocation.
> To resolve this issue, -Xmx256M is explicitly set, matching the Client VM default heap size, ensuring sufficient memory space remains available for JFR.
> I believe that this test verifies that the combination of memory options for JFR is valid or invalid and that the MaxHeapSize setting does not affect the verification.
> Change has been verified locally, test-fix only, no risk.
> 
> Would someone please review this fix?

Looks fine to me.

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24646#pullrequestreview-2768729273