RFR: 8354949: JFR: Split up the EventInstrumentation class [v2]

[Erik Gahlin]

On Thu, 17 Apr 2025 17:26:34 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Build settings and fields only when needed
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/ClassInspector.java line 102:
> 
>> 100:         for (MethodModel method : classModel.methods()) {
>> 101:             String d = method.methodTypeSymbol().descriptorString();
>> 102:             if (method.methodName().equalsString("commit") && m.descriptor().descriptorString().equals(d)) {
> 
> I think we need a `MethodDesc.matches` to conveniently check a (name, methodTypeDesc) tuple matches a NameAndType entry or a MethodModel. This check is repeated a few times in this class.

Good idea.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24726#discussion_r2049588351