RFR: 8354949: JFR: Split up the EventInstrumentation class [v4]

Erik Gahlin egahlin at openjdk.org
Fri Apr 18 12:22:46 UTC 2025


On Thu, 17 Apr 2025 17:28:45 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove accidentally added printStackTrace()
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/ClassInspector.java line 217:
> 
>> 215:         List<AnnotationValue> list = new ArrayList<>();
>> 216:         for (Attribute<?> attribute: classModel.attributes()) {
>> 217:             if (attribute instanceof RuntimeVisibleAnnotationsAttribute rvaa) {
> 
> `findAttribute` or `findAttributes` can be helpful if you just want one attribute.

Agree, but I like to refactor that in a later PR. That part of the code needs a complete rewrite.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24726#discussion_r2050544431


More information about the hotspot-jfr-dev mailing list