RFR: 8364667: JFR: Throttle doesn't work with dynamic events

Markus Grönlund mgronlun at openjdk.org
Tue Aug 5 11:58:03 UTC 2025


On Mon, 4 Aug 2025 22:20:15 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a PR that fixes a bug with dynamic events and the new `@Throttle` annotation?
> 
> If a class is in the boot class loader (isJDK), it only checks for a static commit method and does not check if the `@Throttle` annotation exists (which it does  for dynamic events).
> 
> I added a test, and I also noticed that there is no check to see if there are zero events when shouldCommit is false, so I added that as well.
> 
> Testing: jdk/jdk/jfr
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26632#pullrequestreview-3087965161


More information about the hotspot-jfr-dev mailing list