Integrated: 8364667: JFR: Throttle doesn't work with dynamic events
Erik Gahlin
egahlin at openjdk.org
Tue Aug 5 14:36:10 UTC 2025
On Mon, 4 Aug 2025 22:20:15 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a PR that fixes a bug with dynamic events and the new `@Throttle` annotation?
>
> If a class is in the boot class loader (isJDK), it only checks for a static commit method and does not check if the `@Throttle` annotation exists (which it does for dynamic events).
>
> I added a test, and I also noticed that there is no check to see if there are zero events when shouldCommit is false, so I added that as well.
>
> Testing: jdk/jdk/jfr
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 8a571ee7
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/8a571ee7f2d9a46ff485fd9f3658c552e2d20817
Stats: 52 lines in 3 files changed: 46 ins; 4 del; 2 mod
8364667: JFR: Throttle doesn't work with dynamic events
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.org/jdk/pull/26632
More information about the hotspot-jfr-dev
mailing list