RFR: 8347124: Clean tests with --enable-linkable-runtime

[Alan Bateman]

On Wed, 8 Jan 2025 14:24:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this trivial test-only patch in support of running tests on JEP 493 enabled builds. Both tests use the `ToolProvider` API so as to run `jlink` in-process of the test JVM which includes module patches (as in - uses `--patch-module`) which is not supported for JEP 493 enabled JDKs. The proposed fix is to run those two tests in `/othervm` so as to no longer see the module patch of the test JDK.
> 
> Testing:
> - [ ] GHA
> - [x] Affected tests which fail prior the patch and pass after with a JEP 493 enabled JDK. Also tested on a JDK that includes `jmods` folder.
> 
> Thoughts?

test/jdk/tools/launcher/SourceMode.java line 29:

> 27:  * @summary Test source mode
> 28:  * @modules jdk.compiler jdk.jlink
> 29:  * @run main/othervm SourceMode

This looks fine, might need to add `@comment` to something brief to say why the test are othervm. Also I assume you'll bump the copyright header on the tests before ingtegrating.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22969#discussion_r1907293028