RFR: 8347124: Clean tests with --enable-linkable-runtime [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Wed Jan 8 14:56:56 UTC 2025
On Wed, 8 Jan 2025 14:42:45 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Copyright and @comment
>
> test/jdk/tools/launcher/SourceMode.java line 29:
>
>> 27: * @summary Test source mode
>> 28: * @modules jdk.compiler jdk.jlink
>> 29: * @run main/othervm SourceMode
>
> This looks fine, might need to add `@comment` to something brief to say why the test are othervm. Also I assume you'll bump the copyright header on the tests before ingtegrating.
Thanks. `@comment` added and copyright header updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22969#discussion_r1907309808
More information about the hotspot-jfr-dev
mailing list