RFR: 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac
Severin Gehwolf
sgehwolf at openjdk.org
Mon Jan 13 15:44:55 UTC 2025
Please review this test-only fix. Apparently there are some test configurations out there that run `jdk/jfr/jvm/TestModularImage.java` with limited modules. Specifically `--limit-modules java.base,jdk.jfr`. For this particular test that is not sufficient to be able to run the test. `TestModularImage.java` uses the `ToolProvider` API to get a hold of `javac` as well as for `jlink` without them being present the test should be skipped.
I've done that by adding those two required modules in the `@modules` tag.
Testing:
- [ ] GHA
- [x] `jdk/jfr/jvm/TestModularImage.java` with test option `--limit-modules jdk.jfr,java.base` which now skips the test (instead of failing the test). Running `TestModularImage.java` without the `--limit-modules` option and it passes.
Thoughts?
-------------
Commit messages:
- 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac
Changes: https://git.openjdk.org/jdk/pull/23079/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23079&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8347496
Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/23079.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23079/head:pull/23079
PR: https://git.openjdk.org/jdk/pull/23079
More information about the hotspot-jfr-dev
mailing list