RFR: 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac

[Erik Gahlin]

On Mon, 13 Jan 2025 15:39:19 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this test-only fix. Apparently there are some test configurations out there that run `jdk/jfr/jvm/TestModularImage.java` with limited modules. Specifically `--limit-modules java.base,jdk.jfr`. For this particular test that is not sufficient to be able to run the test. `TestModularImage.java` uses the `ToolProvider` API to get a hold of `javac` as well as for `jlink` without them being present the test should be skipped.
> 
> I've done that by adding those two required modules in the `@modules` tag.
> 
> Testing:
> - [ ] GHA
> - [x] `jdk/jfr/jvm/TestModularImage.java` with test option `--limit-modules jdk.jfr,java.base` which now skips the test (instead of failing the test). Running `TestModularImage.java` without the `--limit-modules` option and it passes.
> 
> Thoughts?

Marked as reviewed by egahlin (Reviewer).

> 
> Thoughts?
> 

Seems reasonable, as long as the created images don't have other modules it should be fines.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23079#pullrequestreview-2547868599
PR Comment: https://git.openjdk.org/jdk/pull/23079#issuecomment-2588178645