RFR: 8361175: JFR: Document differences between method sample events [v2]
Erik Gahlin
egahlin at openjdk.org
Mon Jul 7 10:31:57 UTC 2025
> Could I have a review that clarifies how the method sample events work?
>
> - Added descriptions to NativeMethodSample, ExecutionSample and CPUTimeSample to clarify what they sample and what they don't sample.
> - Removed the word "Method" from the labels of the CPUTimeSample and "ExecutionSample events for consistency and to avoid overly verbose event labels.
> - Added the word "setting" so that the description of CPUTimeSample reads "throttle setting" instead of just "throttle".
> - Changed the label for the CPUTimeSamplesLost event to "CPU Time Samples Lost", making it easier to associate with "CPU Time Sample" event.
> - Removed the percentage column from the "native-methods" view, as normalization doesn't make sense when mixing executing and waiting samples.
>
>
> Testing: tets/jdk/jdk/jfr + tier1
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Fix typo
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26132/files
- new: https://git.openjdk.org/jdk/pull/26132/files/256c268f..80ead0b6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26132&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26132&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/26132.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26132/head:pull/26132
PR: https://git.openjdk.org/jdk/pull/26132
More information about the hotspot-jfr-dev
mailing list