RFR: 8361175: JFR: Document differences between method sample events [v2]

Markus Grönlund mgronlun at openjdk.org
Mon Jul 7 12:35:38 UTC 2025


On Mon, 7 Jul 2025 10:31:57 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review that clarifies how the method sample events work?
>> 
>> - Added descriptions to NativeMethodSample, ExecutionSample and CPUTimeSample to clarify what they sample and what they don't sample.
>> - Removed the word "Method" from the labels of the CPUTimeSample and ExecutionSample events for consistency and to avoid overly verbose event labels.
>> - Added the word "setting" so that the description of CPUTimeSample reads "throttle setting" instead of just "throttle".
>> - Changed the label for the CPUTimeSamplesLost event to "CPU Time Samples Lost", making it easier to associate with "CPU Time Sample" event. 
>> - Removed the percentage column from the "native-methods" view, as normalization doesn't make sense when mixing executing and waiting samples.
>> 
>> 
>> Testing: tets/jdk/jdk/jfr + tier1
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26132#pullrequestreview-2993638311


More information about the hotspot-jfr-dev mailing list