RFR: 8361639: JFR: Incorrect top frame for I/O events
Alan Bateman
alanb at openjdk.org
Wed Jul 16 16:53:40 UTC 2025
On Wed, 9 Jul 2025 05:49:30 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of the change that ensures that the top frame for I/O events is not an internal JDK method, such as FileReadEvent::offer? This change is dependent on [JDK-8361640](https://bugs.openjdk.org/browse/JDK-8361640).
>
> Testing: tier1, tier2 + jdk/jdk/jfr
>
> Thanks
> Erik
test/jdk/jdk/jfr/event/io/TestIOTopFrame.java line 88:
> 86: }
> 87:
> 88: private static void testFileRead() throws Exception {
In addition to java.io, there will be FileRead/FileWrite events recorded for the stream/channels created with Files.newXXX methods.
test/jdk/jdk/jfr/event/io/TestIOTopFrame.java line 200:
> 198: fc.read(buffers[0]); // 19
> 199: if (fc.read(buffers) < 1) { // 20
> 200: throw new Exception("Expected som bytes to be read");
som -> some
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26211#discussion_r2210963422
PR Review Comment: https://git.openjdk.org/jdk/pull/26211#discussion_r2210961074
More information about the hotspot-jfr-dev
mailing list