RFR: 8361639: JFR: Incorrect top frame for I/O events [v2]
Erik Gahlin
egahlin at openjdk.org
Thu Jul 17 10:37:52 UTC 2025
On Wed, 16 Jul 2025 16:51:26 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add support for Files.newXXX + typos
>
> test/jdk/jdk/jfr/event/io/TestIOTopFrame.java line 88:
>
>> 86: }
>> 87:
>> 88: private static void testFileRead() throws Exception {
>
> In addition to java.io, there will be FileRead/FileWrite events recorded for the stream/channels created with Files.newXXX methods.
I added support for Files.newByteChannel, Files.newInputStream and Files.newOutputStream.
I did try to implement it for Files.newBufferedWriter and Files.newBufferedReader, but I didn't want to filter out BufferedReader and BufferedWriter, since they might be used in application stack frames, so I did not include them in the test.
Given that RDP2 begins today, I think this is the best that can be done for JDK 25. We can revisit other top frames later, perhaps with some other mechanism. I filed an issue for this: https://bugs.openjdk.org/browse/JDK-8362491
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26211#discussion_r2212982580
More information about the hotspot-jfr-dev
mailing list