RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v34]

Markus Grönlund mgronlun at openjdk.org
Thu May 22 09:40:57 UTC 2025


On Thu, 22 May 2025 08:10:24 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fetch bcp from context
>
> src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp line 673:
> 
>> 671:   strb(rscratch1, sampling_critical_section);
>> 672:   membar(Assembler::StoreLoad);
>> 673: }
> 
> Which store and load accesses does this StoreLoad fence separate?

The crit sec to be stored before the poll test is issued.

Most likely not needed, because of implicit fences involved in thread suspension.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2102108634


More information about the hotspot-jfr-dev mailing list