RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v34]

Andrew Haley aph at openjdk.org
Thu May 22 10:26:57 UTC 2025


On Thu, 22 May 2025 09:38:34 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> The crit sec to be stored before the poll test is issued.
> 
> Most likely not needed, because of implicit fences involved in thread suspension.

OK, but reading `sampling_critical_section` doesn't seem to have any synchronization at all, so it doesn't much matter what you do when writing it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2102212913


More information about the hotspot-jfr-dev mailing list