RFR: 8365606: Container code should not be using jlong/julong [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 10 13:34:21 UTC 2025
On Fri, 24 Oct 2025 12:03:26 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>> - Fix print_container_info output
>> - whitespace clean-ups and other small fixes
>> - Fix log format in container macro and scanf format
>> - Fix duplicate include in osContainer_linux
>> - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 90:
>
>> 88: if (!is_ok) { \
>> 89: log_trace(os, container)(log_string " failed: -2"); \
>> 90: return false; \
>
> Do we need to keep the `-2` here? Or could we perhaps change to a better message?
We don't need the `-2` here. This was an attempt to keep backwards compatible, but I guess we can change testing code as well (at least those that rely on those trace logs).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510588965
More information about the hotspot-jfr-dev
mailing list