RFR: 8365606: Container code should not be using jlong/julong [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 10 13:42:15 UTC 2025
On Fri, 24 Oct 2025 12:04:51 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>> - Fix print_container_info output
>> - whitespace clean-ups and other small fixes
>> - Fix log format in container macro and scanf format
>> - Fix duplicate include in osContainer_linux
>> - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 93:
>
>> 91: } \
>> 92: if (retval == value_unlimited) { \
>> 93: log_trace(os, container)(log_string " is: -1"); \
>
> Same here, could perhaps do `log_trace(os, container)(log_string " is: unlimited")`instead.
OK. This will likely need some test adjustment, but I'll do that instead of hard-coding those numbers.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510609021
More information about the hotspot-jfr-dev
mailing list