RFR: 8365606: Container code should not be using jlong/julong [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 10 13:42:18 UTC 2025
On Fri, 24 Oct 2025 11:23:05 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>> - Fix print_container_info output
>> - whitespace clean-ups and other small fixes
>> - Fix log format in container macro and scanf format
>> - Fix duplicate include in osContainer_linux
>> - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/cgroupSubsystem_linux.hpp line 105:
>
>> 103: is_ok = controller->read_string(filename, retval, buf_size); \
>> 104: if (!is_ok) { \
>> 105: log_trace(os, container)(log_string " failed: -2"); \
>
> Why this change? Did the constant value change?
Motivation was getting rid of the OSCONTAINER_ERROR constant. The only place where a negative number was still in use. I've just dropped the `: -2` suffix now. It's not very useful (other than in tests).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510615109
More information about the hotspot-jfr-dev
mailing list