RFR: 8365606: Container code should not be using jlong/julong [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 10 14:09:54 UTC 2025
On Mon, 27 Oct 2025 11:32:34 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>> - Fix print_container_info output
>> - whitespace clean-ups and other small fixes
>> - Fix log format in container macro and scanf format
>> - Fix duplicate include in osContainer_linux
>> - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 61:
>
>> 59: * true if the result reference got updated
>> 60: * false if there was an error
>> 61: */
>
> We set result to `-1` and return true on a no share setup here, but return `false` and don't on cgroup v1. The comment is contradicting.
Good catch. Fixed the cgroup v1 code to match the old behaviour (set `-1` in the result reference and return `true` if we read the default value). I think this fixes the issue.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510712320
More information about the hotspot-jfr-dev
mailing list