RFR: 8365606: Container code should not be using jlong/julong [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Mon Nov 10 17:15:50 UTC 2025
On Mon, 10 Nov 2025 14:24:48 GMT, Thomas Fitzsimmons <fitzsim at openjdk.org> wrote:
>> Yes, there is opportunity to change the API. This patch was done to do a 1-to-1 translation of the previous version as much as possible. So I've refrained from doing this in this patch as well. It kept the size of the patch a bit more manageable. Happy to file a follow-up RFE to do this in a separate patch. Thoughts?
>
> Maybe the API as-is is clearer, because it matches the actual `/proc` values. Having thought about it more, it probably doesn't make sense to change the API just to make the implementation's type handling cleaner, so I'd say don't bother with the follow-up RFE.
OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2511346360
More information about the hotspot-jfr-dev
mailing list