RFR: 8365606: Container code should not be using jlong/julong [v2]

Severin Gehwolf sgehwolf at openjdk.org
Mon Nov 10 14:41:47 UTC 2025


On Mon, 27 Oct 2025 13:49:03 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>>  - Fix print_container_info output
>>  - whitespace clean-ups and other small fixes
>>  - Fix log format in container macro and scanf format
>>  - Fix duplicate include in osContainer_linux
>>  - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp line 379:
> 
>> 377:  * Calculate the maximum number of tasks available to the process. Set the
>> 378:  * value in the passed in 'value' reference. The value might be -1 when
>> 379:  * there is no limit.
> 
> How can we get `-1`? Or do you mean `(uint64_t)-1`?

This was meant to say `value_unlimited` if there is `max` in the `pids.max` interface file. Updated the comment and changed the code handling for `VM.info` to handle `value_unlimited`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510823182


More information about the hotspot-jfr-dev mailing list