RFR: 8365606: Container code should not be using jlong/julong [v2]

Severin Gehwolf sgehwolf at openjdk.org
Mon Nov 10 14:55:14 UTC 2025


On Wed, 22 Oct 2025 13:09:36 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

>> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - Merge branch 'master' into jdk-8365606-jlong-julong-refactor
>>  - Fix print_container_info output
>>  - whitespace clean-ups and other small fixes
>>  - Fix log format in container macro and scanf format
>>  - Fix duplicate include in osContainer_linux
>>  - 8365606: Container code should not be using jlong/julong
>
> src/hotspot/os/linux/os_linux.cpp line 220:
> 
>> 218:   if (OSContainer::is_containerized() && OSContainer::available_memory_in_bytes(avail_mem)) {
>> 219:     log_trace(os)("available container memory: " PHYS_MEM_TYPE_FORMAT, avail_mem);
>> 220:     value = avail_mem;
> 
> Should be able to pass in `value` directly instead of using `avail_mem`.

Sure, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27743#discussion_r2510872717


More information about the hotspot-jfr-dev mailing list