RFR: 8366082: Improve queue size computation in CPU-time sampler [v6]

Jaroslav Bachorik jbachorik at openjdk.org
Fri Sep 5 09:28:13 UTC 2025


On Fri, 5 Sep 2025 09:22:02 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix build on non Linux
>
> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 289:
> 
>> 287:     return Atomic::load(&_out_of_stack_walking_iterations);
>> 288:   }
>> 289:   #endif
> 
> Should this be ASSERT of DEBUG_ONLY? 
> Eg. the fields are defined via DEBUG_ONLY.

Hm, is this because of the definition in whitebox.cpp where we need if/else to return default value if not running with ASSERT ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26926#discussion_r2324573741


More information about the hotspot-jfr-dev mailing list