RFR: 8366082: Improve queue size computation in CPU-time sampler [v6]
Johannes Bechberger
jbechberger at openjdk.org
Fri Sep 5 09:28:14 UTC 2025
On Fri, 5 Sep 2025 09:23:34 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:
>> src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp line 289:
>>
>>> 287: return Atomic::load(&_out_of_stack_walking_iterations);
>>> 288: }
>>> 289: #endif
>>
>> Should this be ASSERT of DEBUG_ONLY?
>> Eg. the fields are defined via DEBUG_ONLY.
>
> Hm, is this because of the definition in whitebox.cpp where we need if/else to return default value if not running with ASSERT ?
Per definition of the macros it's the same
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26926#discussion_r2324574706
More information about the hotspot-jfr-dev
mailing list