Minor issue in JVM_GetVersionInfo

Xiaobin Lu Xiaobin.Lu at Sun.COM
Fri Oct 30 11:20:07 PDT 2009


I approved the fix to go into hotspot.

Michael, please let me know your openjdk ID after you sign the 
agreement. I will push that change for you once I get it.

Thanks,

-Xiaobin


On 10/30/09 09:56, Andrew John Hughes wrote:
> 2009/10/30 Michael Starzinger <michi at complang.tuwien.ac.at>:
>   
>> Hello!
>>
>> Some days ago I examined the implementation of JVM_GetVersionInfo and
>> spotted a minor issue. The passed jvm_version_info structure is only
>> partially cleared with memset, because one of the arguments is handled
>> incorrectly. The attached patch should fix the issue.
>>
>> This is the first time I am contributing to OpenJDK, so please let me know
>> if there is anything else I need to do to get this in.
>>
>> -michi
>>
>>
>>
>>     
>
> Hi Michi,
>
> First thing is, have you signed the SCA?
> http://sun.com/software/opensource/sca.pdf  Even though this is a
> trivial patch, Sun requires assignment for all patches.
>
> The patch looks ok to me and still applies to the latest promoted
> HotSpot about to appear in b75.  So once you have the SCA sorted, all
> we need is for one of the HotSpot engineers to approve it, assign it a
> bug ID and push it through JPRT.
>
> For convenience, here's a webrev of the change applied to hotspot-rt:
> http://cr.openjdk.java.net/~andrew/michi/webrev.01/
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20091030/595368c4/attachment.html 


More information about the hotspot-runtime-dev mailing list