Request for review (S): 7100935: win32: memmove is not atomic but is used for pd_conjoint_*_atomic operations

Siebenborn, Axel axel.siebenborn at sap.com
Tue Oct 18 06:15:41 PDT 2011


7100935: win32: memmove is not atomic but is used for  pd_conjoint_*_atomic.

http://www.sapjvm.com/as/webrevs/7100935/

The fix is to replace the call to memmove by a simple copy loop.

I made the fix for windows_x86_64 and for sparc.

I added the tests for copying oops and the copy of short arrays of Volker.

I did not use the template of my original change.
However, win compiler would inline the template and so does gcc. It's strange, that Sun's compiler doesn't.

Axel


More information about the hotspot-runtime-dev mailing list