Request for review (S): 7100935: win32: memmove is not atomic but is used for pd_conjoint_*_atomic operations

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Oct 18 11:40:07 PDT 2011


I think copy code changes look good.

Regression tests need copyright header as other our tests, for example as this 
Volker's test:

http://hg.openjdk.java.net/hsx/hotspot-comp/hotspot/file/e5928e7dab26/test/compiler/6880034/Test6880034.java

In TestShortArraycopy.java move test's descriptor above class declaration as in 
TestConjointAtomicArraycopy.java.

Thanks,
Vladimir

Siebenborn, Axel wrote:
> 7100935: win32: memmove is not atomic but is used for  pd_conjoint_*_atomic.
> 
> http://www.sapjvm.com/as/webrevs/7100935/
> 
> The fix is to replace the call to memmove by a simple copy loop.
> 
> I made the fix for windows_x86_64 and for sparc.
> 
> I added the tests for copying oops and the copy of short arrays of Volker.
> 
> I did not use the template of my original change.
> However, win compiler would inline the template and so does gcc. It's strange, that Sun's compiler doesn't.
> 
> Axel


More information about the hotspot-runtime-dev mailing list