Request for code review (smallest review ever)
James Melvin
james.melvin at oracle.com
Tue Feb 14 13:27:46 PST 2012
I guess a smaller change would be something like 'chmod' a file, etc.
No file mods, just changed attributes.
- Jim
On 2/14/12 4:23 PM, Daniel D. Daugherty wrote:
> Thumbs up!
>
> Dan
>
> P.S.
> I've seen one where it was a single char change so the
> size of the file was the same... yours added a character
> so that would count as bigger... :-)
>
> On 2/14/12 2:20 PM, keith mcguigan wrote:
>>
>> Well, ok, I guess it's not the smallest code change -- I think I've
>> matched this before -- but I guarantee you won't see one smaller than
>> this!
>>
>> It's a one-liner (a one-character-er) to accept 0 as a successful
>> return from an ioctl() call, for registering dtrace providers.
>>
>> http://cr.openjdk.java.net/~kamg/7145589/webrev.00/
>>
>> --
>> - Keith
>>
More information about the hotspot-runtime-dev
mailing list