RFR(S) 8021296 : [TESTBUG] Test8017498.sh fails to find "gcc" and fails to compile on some Linux releases

Yumin Qi yumin.qi at oracle.com
Fri Jul 26 17:15:37 PDT 2013


Looks good.
For first three tests, they are targeting for Linux, so I think move 
checking up in

   21 OS=`uname -s`
   22 case "$OS" in
   23   Linux)
   24     NULL=/dev/null
   25     PS=":"
   26     FS="/"
+        gcc_cmd=`which gcc`
   27     ;;
   28   * )
   29     echo "Test passed; only valid for Linux"
   30     exit 0;
   31     ;;
   32 esac
   33
+ exit here
   34 ${TESTJAVA}${FS}bin${FS}java ${TESTVMOPTS} -Xinternalversion > vm_version.out 2>&1


no need go forward without gcc.

Thanks
Yumin

On 7/26/2013 4:06 PM, Calvin Cheung wrote:
> Please review this small fix for a testcase bug.
>
> webrev: http://cr.openjdk.java.net/~ccheung/8021296/webrev/
>
> JBS: https://jbs.oracle.com/bugs/browse/JDK-8021296
> bug: http://bugs.sun.com/view_bug.do?bug_id=8021296
>
> Fixing 2 issues:
> 1) gcc not found on the test machine
>     In the sh script, check for if gcc exists. If it doesn't exist, 
> declare the test as "Passed".
> 2) REG_RIP undeclared
>     REG_RIP is only defined for 64-bit linux. The compile failure was 
> seen on 32-bit platform.
>     The fix is to check for 64-bit platform - use REG_RIP for 64-bit 
> and REG_EFL for 32-bit.
>     They both have a value of 16.
>
> Testing:
>     Ran jtreg on the testcases and making sure it reports "Passed" if 
> gcc isn't found.
>
> thanks,
> Calvin
>
>
>
>



More information about the hotspot-runtime-dev mailing list