Review request for JDK-8009729: Refix hotspot jni_<cpu>.h JNIEXPORT and JNIIMPORT definitions to match jdk version
Coleen Phillimore
coleen.phillimore at oracle.com
Tue May 7 10:04:27 PDT 2013
These files match now! Can you add a comment to each that says not to
change these without changing the matching jni_md.h in the jdk?
+comment, this looks fine.
thanks!
Coleen
On 05/07/2013 12:01 PM, Eric McCorkle wrote:
> Can someone give this a look so it can go in?
>
> On 05/07/13 00:55, David Holmes wrote:
>> On 4/05/2013 1:29 AM, Eric McCorkle wrote:
>>> Does anyone have any comments on this patch, or is it good to go?
>> This looks good to go - it is consistent with the changes already in the
>> JDK jni_md.h files.
>>
>> You need a second reviewer though (small 'r')
>>
>> David
>>
>>> On 05/01/13 16:56, Eric McCorkle wrote:
>>>> Hello,
>>>>
>>>> Please review this patch, which updates the definitions of JNIEXPORT and
>>>> JNIIMPORT to use the __has_attribute macro.
>>>>
>>>> The webrev is here
>>>> http://cr.openjdk.java.net/~emc/8009729/
>>>>
>>>> Thanks,
>>>> Eric
>>>>
More information about the hotspot-runtime-dev
mailing list