JDK-8027113 fix for jdk 9 code review updated

[Daniel D. Daugherty]

On 1/27/14 9:18 PM, Ron Durbin wrote:
> JDK-8027113 decouples the '-XXaltjvm=<path>' option from the gamma launcher
>
> Web URL http://cr.openjdk.java.net/~rdurbin/JDK-8027113-cr1-webrev

Thumbs up modulo one piece of script paranoia...

make/Makefile
     No comments.

make/hotspot.script
     lines 111-115 should only be done if "$JDK" is non-NULL so
     something like:

     if [ -n "$JDK" ]; then
     ...
     fi

     around that logic. Sorry I missed that on the earlier review.

src/os/bsd/vm/os_bsd.cpp
src/os/linux/vm/os_linux.cpp
src/os/solaris/vm/os_solaris.cpp
src/os/windows/vm/os_windows.cpp
     No comments.

src/share/tools/ProjectCreator/WinGammaPlatformVC10.java
     Good example for showing how to get into this "feature";
     easier to see than hotspot.script.

src/share/vm/runtime/arguments.cpp
     No comment (this arg processing stuff hurts my brain).

src/share/vm/runtime/arguments.hpp
     No comment.

Dan


>
> Internal URL: http://javaweb.us.oracle.com/~rdurbin/JDK-8027113-cr1-webrev
>
> Summary:
> Refactor the code so that it is no longer tightly coupled with the "gamma launcher". This will allow work on the following bug to proceed:
>
>      JDK-8005262 possible gamma launcher issues
>
> Testing included:
>     JPRT run
>     Manual launcher tests on:
> 	Win7-64 Cygwin,
> 	Win7-64 VS2010.
> 	Solaris 64 bit
>       Linux 64 bit