JDK-8027113 fix for jdk 9 code review updated

[Ron Durbin]

Dan

Thank you for your review and comments.

You made the following comment

> make/hotspot.script
>      lines 111-115 should only be done if "$JDK" is non-NULL so
>      something like:
> 
>      if [ -n "$JDK" ]; then
>      ...
>      fi
> 
>      around that logic. Sorry I missed that on the earlier review.
> 

Here is a diff of the change I have made to the code to resolve this.

@@ -101,9 +108,16 @@ else
 else
     JDK=@@JDK_IMPORT_PATH@@
 fi
-
-if [ "${JDK}" = "" ]; then
-    echo "Failed to find JDK.  Either ALT_JAVA_HOME is not set or JDK_IMPORT_PATH is empty."
+if [ "${JDK}" != "" ]; then
+    case "$OS" in
+    CYGWIN*)
+        JDK=`cygpath -m "$JDK"`
+        ;;
+    esac
+else
+    echo "Failed to find JDK." \
+        "Either ALT_JAVA_HOME is not set or JDK_IMPORT_PATH is empty."
+    exit 1
 fi

 # We will set the LD_LIBRARY_PATH as follows:

> -----Original Message-----
> From: Daniel D. Daugherty
> Sent: Tuesday, January 28, 2014 5:11 PM
> To: Ron Durbin
> Cc: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: JDK-8027113 fix for jdk 9 code review updated
> 
> On 1/27/14 9:18 PM, Ron Durbin wrote:
> > JDK-8027113 decouples the '-XXaltjvm=<path>' option from the gamma launcher
> >
> > Web URL http://cr.openjdk.java.net/~rdurbin/JDK-8027113-cr1-webrev
> 
> Thumbs up modulo one piece of script paranoia...
> 
> make/Makefile
>      No comments.
> 
> make/hotspot.script
>      lines 111-115 should only be done if "$JDK" is non-NULL so
>      something like:
> 
>      if [ -n "$JDK" ]; then
>      ...
>      fi
> 
>      around that logic. Sorry I missed that on the earlier review.
> 
> src/os/bsd/vm/os_bsd.cpp
> src/os/linux/vm/os_linux.cpp
> src/os/solaris/vm/os_solaris.cpp
> src/os/windows/vm/os_windows.cpp
>      No comments.
> 
> src/share/tools/ProjectCreator/WinGammaPlatformVC10.java
>      Good example for showing how to get into this "feature";
>      easier to see than hotspot.script.
> 
> src/share/vm/runtime/arguments.cpp
>      No comment (this arg processing stuff hurts my brain).
> 
> src/share/vm/runtime/arguments.hpp
>      No comment.
> 
> Dan
> 
> 
> >
> > Internal URL: http://javaweb.us.oracle.com/~rdurbin/JDK-8027113-cr1-webrev
> >
> > Summary:
> > Refactor the code so that it is no longer tightly coupled with the "gamma launcher". This
> will allow work on the following bug to proceed:
> >
> >      JDK-8005262 possible gamma launcher issues
> >
> > Testing included:
> >     JPRT run
> >     Manual launcher tests on:
> > 	Win7-64 Cygwin,
> > 	Win7-64 VS2010.
> > 	Solaris 64 bit
> >       Linux 64 bit
>