RFR (M/XXS) cleanup more non-indent white space issues (8047156)

[Daniel D. Daugherty]

On 6/18/14 11:45 AM, Coleen Phillimore wrote:
>
> This looks good.

Thanks for the review!


> Looks like the copy of PlatformEvent in os_aix.hpp didn't copy the 
> wrong whitespace changes.

The AIX port is missing several of the Contended Locking fixes.
In particular, this one:

JDK-8004902 correctness fixes motivated by contended locking work (6607129)

that I pushed in January of 2013 doesn't appear to be there.

I will need to do a complete audit of the Contended Locking changes
and which ones are missing from AIX. That work will need to be done
separately from my current set of Contended Locking buckets.

Dan


>
> Thanks,
> Coleen
>
>
> On 6/18/14, 12:26 AM, Daniel D. Daugherty wrote:
>> Thanks for the fast review!
>>
>> Dan
>>
>>
>> On 6/17/14 8:12 PM, serguei.spitsyn at oracle.com wrote:
>>> Looks good.
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>> On 6/17/14 6:12 PM, Daniel D. Daugherty wrote:
>>>> Greetings,
>>>>
>>>> I forgot to update my list of files to clean for the latest version
>>>> of the cleanup bucket so I missed these seven files when I sent out
>>>> the review for:
>>>>
>>>>     JDK-8046758 cleanup non-indent white space issues prior to 
>>>> Contended
>>>>                 Locking cleanup bucket
>>>>     https://bugs.openjdk.java.net/browse/JDK-8046758
>>>>
>>>> I have the fix for the following bug ready for JDK9 RT_Baseline:
>>>>
>>>>     JDK-8047156 cleanup more non-indent white space issues prior to
>>>>                 Contended Locking cleanup bucket
>>>>     https://bugs.openjdk.java.net/browse/JDK-8047156
>>>>
>>>> This is both a (M)edium and e(X)tra e(X)tra (S)mall review! Here is 
>>>> the
>>>> URL for the (M)edium webrev:
>>>>
>>>> http://cr.openjdk.java.net/~dcubed/8047156-webrev/0-jdk9-hs-rt/
>>>>
>>>> Since these are white space fixes, I recommend the udiff links instead
>>>> of the frames links. Of course, some folks prefer the patch file 
>>>> itself
>>>> for white space fixes.
>>>>
>>>> Here is the URL for the e(X)tra e(X)tra (S)mall webrev which was 
>>>> generated with a version of webrev that ignores all whitespace 
>>>> changes:
>>>>
>>>> http://cr.openjdk.java.net/~dcubed/8047156-webrev/0-jdk9-hs-rt-no_ws/
>>>>
>>>> Again, I recommend the udiff links since that's the fastest way to see
>>>> that webrev_no_ws found no non-white space changes. The patch file for
>>>> this webrev shows all the white space changes.
>>>>
>>>> Thanks, in advance, for any comments, questions or suggestions.
>>>>
>>>> At the end of the review cycle for this fix, I will attach the 
>>>> version of the do_space_filter.ksh script used to do the work to 
>>>> JDK-8047156.
>>>>
>>>> Dan
>>>>
>>>>
>>>
>>
>