RFR (XS) 8056971 - Minor class loading clean-up

[David Holmes]

On 1/09/2014 1:02 PM, Ioi Lam wrote:
>
> On 8/31/14, 3:34 PM, David Holmes wrote:
>> Looks okay.
>>
>> src/share/vm/classfile/sharedPathsMiscInfo.cpp seems to have an empty
>> set of changes
>>
> There was a deletion of a single space character in this file, but
> webrev doesn't list the white-space-only changes ....

Ah right - this one:

  142         if (filesize  != st.st_size) {

Extra space before != was removed.

Thanks,
David

> - Ioi
>
>> Thanks,
>> David
>>
>>
>> On 1/09/2014 4:55 AM, Ioi Lam wrote:
>>> Please review a very small fix:
>>>
>>> http://cr.openjdk.java.net/~iklam/8056971_classloader_cleanup/
>>>
>>> Bug: Minor class loading clean-up
>>>
>>>      https://bugs.openjdk.java.net/browse/JDK-8056971
>>>
>>> Summary of fix:
>>>
>>>      Code review after the push of JDK-8046070 (Class Data Sharing
>>> cleanup and refactoring)
>>>      has found some minor issues:
>>>
>>>      + Misplacement of #if INCLUE_CDS
>>>      + typos
>>>      + unnecessary C string duplication
>>>        -> in fixing this I converted a bunch of unnecessary
>>>           "char*" to "const char*"
>>>
>>> Tests:
>>>
>>>      JPRT
>>>      UTE vm.quick.testlist, vm.parallel_class_loading.testlist
>>>
>>> Thanks
>>> - Ioi
>