(XS) RFR: 8056183: os::is_MP() always reports true when NMT is enabled
Bertrand Delsart
bertrand.delsart at oracle.com
Tue Sep 9 11:13:23 UTC 2014
Looks good,
Bertrand (not a Reviewer).
On 09/09/14 10:30, David Holmes wrote:
> On 9/09/2014 6:25 PM, Aleksey Shipilev wrote:
>> On 09/09/2014 12:21 PM, David Holmes wrote:
>>> Updated webrev:
>>>
>>> http://cr.openjdk.java.net/~dholmes/8056183/webrev.v2/
>>
>> Looks good. Does it makes sense to merge the _processor_count checks? I
>> think it clearly tells what we consider an "MP" system:
>>
>> return (_processor_count != 1) || AssumeMP;
>
> As long as some micro-optimization geek doesn't jump on me for replacing
> a > check with a != :)
>
> http://cr.openjdk.java.net/~dholmes/8056183/webrev.v3/
>
> Thanks,
> David
>
>> -Aleksey.
>>
--
Bertrand Delsart, Grenoble Engineering Center
Oracle, 180 av. de l'Europe, ZIRST de Montbonnot
38334 Saint Ismier, FRANCE
bertrand.delsart at oracle.com Phone : +33 4 76 18 81 23
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
NOTICE: This email message is for the sole use of the intended
recipient(s) and may contain confidential and privileged
information. Any unauthorized review, use, disclosure or
distribution is prohibited. If you are not the intended recipient,
please contact the sender by reply email and destroy all copies of
the original message.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
More information about the hotspot-runtime-dev
mailing list