RFR 8076492: Make common code from template interpreter code

Yumin Qi yumin.qi at oracle.com
Wed Apr 1 17:44:18 UTC 2015


I like the changes! only a nit:

   I think you want to make function names aligned in 
interpreterRuntime.hpp, so maybe add extra spaces for

+   // Calls
+   static void resolve_invoke(JavaThread* thread, Bytecodes::Code bytecode);
+   static void resolve_invokehandle (JavaThread* thread);
+   static void resolve_invokedynamic(JavaThread* thread);
  
  or just keep the original form:  

-   // Calls
-   static void    resolve_invoke       (JavaThread* thread, Bytecodes::Code bytecode);
-   static void    resolve_invokehandle (JavaThread* thread);
-   static void    resolve_invokedynamic(JavaThread* thread);
-

Thanks
Yumin

On 4/1/2015 10:24 AM, Coleen Phillimore wrote:
> Summary: Move case statement out of assembly code
>
> Tested with JPRT for all (most) platforms - please verify AARCH64.
> Also ran specjbb2005 with linux x64 - not a twitch in performance change.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8076492/
> bug link https://bugs.openjdk.java.net/browse/JDK-8076492
>
> This code is helpful for some class redefinition improvements that 
> I've been prototyping.
>
> Thanks,
> Coleen



More information about the hotspot-runtime-dev mailing list