RFR 8076492: Make common code from template interpreter code

Coleen Phillimore coleen.phillimore at oracle.com
Wed Apr 1 18:47:06 UTC 2015


Thank you for the quick review Yumin!   Especially since you were last 
in this code.

On 4/1/15, 1:44 PM, Yumin Qi wrote:
> I like the changes! only a nit:
>
>   I think you want to make function names aligned in 
> interpreterRuntime.hpp, so maybe add extra spaces for
> +   // Calls
> +   static void resolve_invoke(JavaThread* thread, Bytecodes::Code bytecode);
> +   static void resolve_invokehandle (JavaThread* thread);
> +   static void resolve_invokedynamic(JavaThread* thread);
>   
>   or just keep the original form:  
> -   // Calls
> -   static void    resolve_invoke       (JavaThread* thread, Bytecodes::Code bytecode);
> -   static void    resolve_invokehandle (JavaThread* thread);
> -   static void    resolve_invokedynamic(JavaThread* thread);
> -

I'd rather not line up the functions.  This causes the lines to wrap in 
my windows (only 88 chars wide with enormous fonts).  I think lining up 
functions makes sense in small classes but it this class is too big and 
I don't think it aids readability.

thanks,
Coleen
>
> Thanks
> Yumin
> On 4/1/2015 10:24 AM, Coleen Phillimore wrote:
>> Summary: Move case statement out of assembly code
>>
>> Tested with JPRT for all (most) platforms - please verify AARCH64.
>> Also ran specjbb2005 with linux x64 - not a twitch in performance 
>> change.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8076492/
>> bug link https://bugs.openjdk.java.net/browse/JDK-8076492
>>
>> This code is helpful for some class redefinition improvements that 
>> I've been prototyping.
>>
>> Thanks,
>> Coleen
>



More information about the hotspot-runtime-dev mailing list